Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Try to appease GraphQL backcompat test #25304

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

hellendag
Copy link
Member

@hellendag hellendag commented Oct 16, 2024

Summary & Motivation

Update imports to try to fix backcompat error.

How I Tested These Changes

Buildkite

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hellendag and the rest of your teammates on Graphite Graphite

Copy link

github-actions bot commented Oct 16, 2024

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-ox412l04m-elementl.vercel.app
https://dish-backcompat-attempt.core-storybook.dagster-docs.io

Built with commit 8634d8e.
This pull request is being automatically deployed with vercel-action

import {MetadataEntryFragment} from './types/MetadataEntryFragment.types';
import {
MetadataEntryFragment,
TableMetadataEntryFragment,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Importing the fragment instead of the TableMetadataEntry type allows us to avoid types that aren't included in the fragment.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aha

@hellendag hellendag marked this pull request as ready for review October 16, 2024 01:55
@hellendag hellendag changed the title Let's see if we can appease the backcompat test [ui] Try to appease GraphQL backcompat test Oct 16, 2024
@hellendag hellendag merged commit 6cd7c67 into master Oct 16, 2024
2 checks passed
@hellendag hellendag deleted the dish/backcompat-attempt branch October 16, 2024 02:12
shalabhc pushed a commit that referenced this pull request Oct 16, 2024
## Summary & Motivation

Update imports to try to fix backcompat error.

## How I Tested These Changes

Buildkite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants