Let's see if we can appease the backcompat test

dagster-io · Oct 16, 2024 · 739ed32 · 739ed32
1 parent e12a401
commit 739ed32
Show file tree

Hide file tree

Showing 17 changed files with 73 additions and 39 deletions.
diff --git a/js_modules/dagster-ui/packages/ui-core/client.json b/js_modules/dagster-ui/packages/ui-core/client.json
diff --git a/js_modules/dagster-ui/packages/ui-core/src/asset-graph/types/AssetGraphJobSidebar.types.ts b/js_modules/dagster-ui/packages/ui-core/src/asset-graph/types/AssetGraphJobSidebar.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/asset-graph/types/SidebarAssetInfo.types.ts b/js_modules/dagster-ui/packages/ui-core/src/asset-graph/types/SidebarAssetInfo.types.ts
diff --git a/.../packages/ui-core/src/assets/AutoMaterializePolicyPage/types/GetEvaluationsQuery.types.ts b/.../packages/ui-core/src/assets/AutoMaterializePolicyPage/types/GetEvaluationsQuery.types.ts
diff --git a/.../dagster-ui/packages/ui-core/src/assets/asset-checks/types/AssetCheckDetailModal.types.ts b/.../dagster-ui/packages/ui-core/src/assets/asset-checks/types/AssetCheckDetailModal.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/assets/asset-checks/types/AssetChecks.types.ts b/js_modules/dagster-ui/packages/ui-core/src/assets/asset-checks/types/AssetChecks.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/assets/types/AssetPartitionDetail.types.ts b/js_modules/dagster-ui/packages/ui-core/src/assets/types/AssetPartitionDetail.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/assets/types/AssetView.types.ts b/js_modules/dagster-ui/packages/ui-core/src/assets/types/AssetView.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/assets/types/useLatestPartitionEvents.types.ts b/js_modules/dagster-ui/packages/ui-core/src/assets/types/useLatestPartitionEvents.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/assets/types/useRecentAssetEvents.types.ts b/js_modules/dagster-ui/packages/ui-core/src/assets/types/useRecentAssetEvents.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/metadata/MetadataEntry.tsx b/js_modules/dagster-ui/packages/ui-core/src/metadata/MetadataEntry.tsx
@@ -18,13 +18,16 @@ import {Link} from 'react-router-dom';
 import styled from 'styled-components';
 
 import {TableSchema} from './TableSchema';
-import {MetadataEntryFragment} from './types/MetadataEntryFragment.types';
+import {
+  MetadataEntryFragment,
+  TableMetadataEntryFragment,
+} from './types/MetadataEntryFragment.types';
 import {copyValue} from '../app/DomUtils';
 import {assertUnreachable} from '../app/Util';
 import {displayNameForAssetKey} from '../asset-graph/Utils';
 import {assetDetailsPathForKey} from '../assets/assetDetailsPathForKey';
 import {CodeLink, getCodeReferenceKey} from '../code-links/CodeLink';
-import {IntMetadataEntry, MaterializationEvent, TableMetadataEntry} from '../graphql/types';
+import {IntMetadataEntry, MaterializationEvent} from '../graphql/types';
 import {TimestampDisplay} from '../schedules/TimestampDisplay';
 import {Markdown} from '../ui/Markdown';
 import {NotebookButton} from '../ui/NotebookButton';
@@ -366,7 +369,7 @@ const MetadataEntryModalAction = (props: {
   );
 };
 
-export const TableMetadataEntryComponent = ({entry}: {entry: TableMetadataEntry}) => {
+export const TableMetadataEntryComponent = ({entry}: {entry: TableMetadataEntryFragment}) => {
   const [showSchema, setShowSchema] = React.useState(false);
 
   const schema = entry.table.schema;

diff --git a/js_modules/dagster-ui/packages/ui-core/src/metadata/MetadataEntryFragment.tsx b/js_modules/dagster-ui/packages/ui-core/src/metadata/MetadataEntryFragment.tsx
@@ -65,12 +65,7 @@ export const METADATA_ENTRY_FRAGMENT = gql`
       }
     }
     ... on TableMetadataEntry {
-      table {
-        records
-        schema {
-          ...TableSchemaFragment
-        }
-      }
+      ...TableMetadataEntryFragment
     }
     ... on TableSchemaMetadataEntry {
       ...TableSchemaForMetadataEntry
@@ -91,6 +86,16 @@ export const METADATA_ENTRY_FRAGMENT = gql`
     }
   }
 
+  fragment TableMetadataEntryFragment on TableMetadataEntry {
+    label
+    table {
+      records
+      schema {
+        ...TableSchemaFragment
+      }
+    }
+  }
+
   fragment TableSchemaForMetadataEntry on TableSchemaMetadataEntry {
     schema {
       ...TableSchemaFragment

diff --git a/js_modules/dagster-ui/packages/ui-core/src/metadata/types/MetadataEntryFragment.types.ts b/js_modules/dagster-ui/packages/ui-core/src/metadata/types/MetadataEntryFragment.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/pipelines/types/PipelineExplorerRoot.oss.types.ts b/js_modules/dagster-ui/packages/ui-core/src/pipelines/types/PipelineExplorerRoot.oss.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/runs/types/LogsProvider.types.ts b/js_modules/dagster-ui/packages/ui-core/src/runs/types/LogsProvider.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/typeexplorer/types/TypeExplorerContainer.types.ts b/js_modules/dagster-ui/packages/ui-core/src/typeexplorer/types/TypeExplorerContainer.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/workspace/types/GraphRoot.types.ts b/js_modules/dagster-ui/packages/ui-core/src/workspace/types/GraphRoot.types.ts