-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.9] Update evaluation id logic to be in sync with tick ids #25269
Open
OwenKephart
wants to merge
1
commit into
10-17-add-automation-condition-to-observable-source-asset
Choose a base branch
from
10-14-_wip_update_evaluation_id_logic
base: 10-17-add-automation-condition-to-observable-source-asset
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[1.9] Update evaluation id logic to be in sync with tick ids #25269
OwenKephart
wants to merge
1
commit into
10-17-add-automation-condition-to-observable-source-asset
from
10-14-_wip_update_evaluation_id_logic
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 14, 2024
This was referenced Oct 14, 2024
OwenKephart
force-pushed
the
10-10-create_default_automation_condition_sensor_in_definitions_object
branch
from
October 14, 2024 23:02
ad63e1b
to
a539d0e
Compare
OwenKephart
force-pushed
the
10-14-_wip_update_evaluation_id_logic
branch
from
October 14, 2024 23:03
0d03b8a
to
6f38e2c
Compare
OwenKephart
force-pushed
the
10-10-create_default_automation_condition_sensor_in_definitions_object
branch
from
October 14, 2024 23:11
a539d0e
to
9e40e7a
Compare
OwenKephart
force-pushed
the
10-14-_wip_update_evaluation_id_logic
branch
from
October 14, 2024 23:11
6f38e2c
to
ea5f33c
Compare
OwenKephart
force-pushed
the
10-10-create_default_automation_condition_sensor_in_definitions_object
branch
from
October 15, 2024 17:33
9e40e7a
to
0eccef5
Compare
OwenKephart
force-pushed
the
10-14-_wip_update_evaluation_id_logic
branch
from
October 15, 2024 17:33
ea5f33c
to
9649d9d
Compare
OwenKephart
force-pushed
the
10-10-create_default_automation_condition_sensor_in_definitions_object
branch
from
October 15, 2024 17:56
0eccef5
to
a57483a
Compare
OwenKephart
force-pushed
the
10-14-_wip_update_evaluation_id_logic
branch
from
October 15, 2024 17:56
9649d9d
to
51521fd
Compare
OwenKephart
force-pushed
the
10-10-create_default_automation_condition_sensor_in_definitions_object
branch
from
October 15, 2024 18:59
a57483a
to
bb8b0f1
Compare
OwenKephart
force-pushed
the
10-14-_wip_update_evaluation_id_logic
branch
from
October 15, 2024 19:00
51521fd
to
4fe29d2
Compare
OwenKephart
force-pushed
the
10-10-create_default_automation_condition_sensor_in_definitions_object
branch
from
October 15, 2024 21:09
bb8b0f1
to
99f09d6
Compare
OwenKephart
force-pushed
the
10-14-_wip_update_evaluation_id_logic
branch
from
October 15, 2024 21:09
4fe29d2
to
cba16f1
Compare
OwenKephart
force-pushed
the
10-10-create_default_automation_condition_sensor_in_definitions_object
branch
from
October 16, 2024 23:37
99f09d6
to
9ade09f
Compare
OwenKephart
force-pushed
the
10-14-_wip_update_evaluation_id_logic
branch
from
October 16, 2024 23:37
cba16f1
to
8c6150c
Compare
OwenKephart
force-pushed
the
10-10-create_default_automation_condition_sensor_in_definitions_object
branch
from
October 16, 2024 23:46
9ade09f
to
f2008ea
Compare
OwenKephart
force-pushed
the
10-14-_wip_update_evaluation_id_logic
branch
from
October 16, 2024 23:46
8c6150c
to
eb403b4
Compare
OwenKephart
force-pushed
the
10-10-create_default_automation_condition_sensor_in_definitions_object
branch
from
October 17, 2024 00:20
f2008ea
to
8bd71f8
Compare
OwenKephart
force-pushed
the
10-14-_wip_update_evaluation_id_logic
branch
from
October 17, 2024 00:21
eb403b4
to
2c86028
Compare
OwenKephart
force-pushed
the
10-10-create_default_automation_condition_sensor_in_definitions_object
branch
from
October 17, 2024 16:39
8bd71f8
to
fdd6922
Compare
OwenKephart
force-pushed
the
10-14-_wip_update_evaluation_id_logic
branch
from
October 17, 2024 16:39
2c86028
to
4804b8b
Compare
OwenKephart
force-pushed
the
10-14-_wip_update_evaluation_id_logic
branch
from
October 17, 2024 18:02
4804b8b
to
7c398a7
Compare
OwenKephart
changed the base branch from
10-10-create_default_automation_condition_sensor_in_definitions_object
to
10-17-add-automation-condition-to-observable-source-asset
October 17, 2024 18:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
When running in user-code mode, evaluation ids are always based off of the tick id. This prevents us from having to deserialize the AssetDaemonCursor server side, and just in general is an easier way of producing monotonically increasing integers across multiple values.
In general, the tick id is guaranteed to be strictly larger than the AssetDaemonCursor value, as the daemon cursor (unless manually edited) cannot increase without a new tick being created. This means that it is safe to switch from daemon-mode to user-mode, but if you switch from user-mode back to daemon-mode, you could end up with an evaluation id that was much smaller, with the end result being that new evaluation records you produce would have a lower evaluation_id than older ones, messing up the history.
This change makes it so that the daemon-mode id will stay in sync with the tick id, avoiding this issue.
How I Tested These Changes
Existing tests, with some small updates.
Changelog
NOCHANGELOG