Store allow_backfills in the sensor metadata #25203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 10, 2024
This was referenced Oct 10, 2024
OwenKephart
force-pushed
the
10-10-create_backfill_in_progress_automationcondition
branch
from
df8311b
to
83eb88d
Compare
OwenKephart
force-pushed
the
10-10-store_allow_backfills_in_the_sensor_metadata
branch
from
befafe9
to
32eeb3d
Compare
This was referenced Oct 11, 2024
schrockn
reviewed
Oct 11, 2024
python_modules/dagster/dagster/_core/definitions/automation_condition_sensor_definition.py
Outdated
Show resolved
Hide resolved
OwenKephart
force-pushed
the
10-10-create_backfill_in_progress_automationcondition
branch
from
83eb88d
to
d163030
Compare
OwenKephart
force-pushed
the
10-10-store_allow_backfills_in_the_sensor_metadata
branch
from
32eeb3d
to
9be9003
Compare
OwenKephart
force-pushed
the
10-10-create_backfill_in_progress_automationcondition
branch
from
d163030
to
55db5d0
Compare
OwenKephart
force-pushed
the
10-10-store_allow_backfills_in_the_sensor_metadata
branch
2 times, most recently
from
66e90c3
to
08182f2
Compare
OwenKephart
dismissed
schrockn’s stale review
Went with emit_backfills, which I agree is better. Did a little chatGPT searching for a better name and was not successful. Ideally, this will be a pretty niche option for people to turn off.
OwenKephart
force-pushed
the
10-10-create_backfill_in_progress_automationcondition
branch
from
55db5d0
to
e6aa284
Compare
OwenKephart
force-pushed
the
10-10-store_allow_backfills_in_the_sensor_metadata
branch
from
08182f2
to
4d6ab5b
Compare
OwenKephart
force-pushed
the
10-10-create_backfill_in_progress_automationcondition
branch
from
e6aa284
to
2726512
Compare
OwenKephart
force-pushed
the
10-10-store_allow_backfills_in_the_sensor_metadata
branch
from
4d6ab5b
to
09c9bd8
Compare
OwenKephart
force-pushed
the
10-10-create_backfill_in_progress_automationcondition
branch
from
2726512
to
363b5d2
Compare
OwenKephart
force-pushed
the
10-10-store_allow_backfills_in_the_sensor_metadata
branch
from
09c9bd8
to
206a6ff
Compare
OwenKephart
force-pushed
the
10-10-create_backfill_in_progress_automationcondition
branch
from
363b5d2
to
29d740e
Compare
OwenKephart
force-pushed
the
10-10-store_allow_backfills_in_the_sensor_metadata
branch
from
206a6ff
to
9c81ee7
Compare
OwenKephart
force-pushed
the
10-10-create_backfill_in_progress_automationcondition
branch
from
29d740e
to
dd22d6e
Compare
OwenKephart
force-pushed
the
10-10-store_allow_backfills_in_the_sensor_metadata
branch
from
9c81ee7
to
f641df4
Compare
schrockn
approved these changes
Oct 15, 2024
OwenKephart
force-pushed
the
10-10-create_backfill_in_progress_automationcondition
branch
from
dd22d6e
to
24e4be2
Compare
OwenKephart
force-pushed
the
10-10-store_allow_backfills_in_the_sensor_metadata
branch
from
f641df4
to
307febf
Compare
OwenKephart
force-pushed
the
10-10-create_backfill_in_progress_automationcondition
branch
4 times, most recently
from
1c77260
to
b4b92a8
Compare
Base automatically changed from
10-10-create_backfill_in_progress_automationcondition
to
master
October 15, 2024 20:06
OwenKephart
force-pushed
the
10-10-store_allow_backfills_in_the_sensor_metadata
branch
from
307febf
to
dd36b71
Compare
OwenKephart
deleted the
10-10-store_allow_backfills_in_the_sensor_metadata
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This allows it to be transferred across the serdes boundary, enabling it for non-user code automation conditions
How I Tested These Changes
Changelog
NOCHANGELOG