Problem: Restore don't work with snapshot revert usage #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
force-pushed
the
cleanup-store-api
branch
from
01ca692
to
bdaaf38
Compare
yihuang
changed the title
yihuang
commented
Apr 1, 2024
yihuang
force-pushed
the
cleanup-store-api
branch
from
356d873
to
eabb107
Compare
11 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+132
to
+134
| for _, store := range cms.stores { | ||
| store.Discard() | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
Comment on lines
+188
to
+190
| for k, v := range cms.stores { | ||
| stores[k] = v.(types.BranchStore).Clone().(types.CacheWrap) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
Comment on lines
+207
to
+212
| for k, v := range cms.stores { | ||
| if _, ok := other.stores[k]; !ok { | ||
| // clear the cache store if it's not in the other | ||
| v.Discard() | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
mmsqe
approved these changes
Apr 2, 2024
Solution: - fix and add test to support the usage pattern in ethermint add Discard method to CacheWrap better testing reorder fix bug
yihuang
force-pushed
the
cleanup-store-api
branch
from
37956ee
to
d367990
Compare
yihuang
merged commit ec314e8
into
crypto-org-chain:release/v0.50.x
43 of 45 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution:
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...