Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: custom cache store impl not unified with sdk #446

Merged
merged 6 commits into from
Apr 2, 2024

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Apr 1, 2024

Solution:

  • Reuse the refactored cache store with sdk

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@yihuang yihuang requested a review from mmsqe April 1, 2024 09:47
CHANGELOG.md Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 75.67568% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 63.36%. Comparing base (e3e4649) to head (1881ab2).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #446      +/-   ##
===========================================
+ Coverage    62.56%   63.36%   +0.80%     
===========================================
  Files          130      125       -5     
  Lines        12513    12061     -452     
===========================================
- Hits          7829     7643     -186     
+ Misses        4138     3875     -263     
+ Partials       546      543       -3     
Files Coverage Δ
app/app.go 82.21% <100.00%> (-0.19%) ⬇️
x/evm/keeper/keeper.go 89.15% <ø> (-0.20%) ⬇️
x/evm/statedb/native.go 100.00% <100.00%> (ø)
x/evm/statedb/statedb.go 80.95% <71.87%> (-0.84%) ⬇️

Solution:
- unify the refactored cache store with sdk

Update CHANGELOG.md

Signed-off-by: yihuang <[email protected]>

mount object stores

fix

fix test

cleanup

fix ctx

fix lint
@yihuang yihuang enabled auto-merge (squash) April 2, 2024 02:08
x/evm/statedb/statedb.go Outdated Show resolved Hide resolved
x/evm/statedb/statedb.go Outdated Show resolved Hide resolved
x/evm/statedb/statedb.go Outdated Show resolved Hide resolved
@yihuang yihuang merged commit 59586a5 into crypto-org-chain:develop Apr 2, 2024
38 of 39 checks passed
@yihuang yihuang deleted the unify-store branch April 2, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants