Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the section parsing due to section name not being parsed properly #491

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed the section parsing due to section name not being parsed properly #491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
959da39
Fixed the section parsing due to section name not being parsed properly
anmolsahoo25 Mar 11, 2018
f5ff849
Created a custom opener for files and added the headers to it
anmolsahoo25 Mar 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion edx_dl/edx_dl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,7 +715,12 @@ def download_url(url, filename, headers, args):
# order) is due to different behaviors in different Python versions
# (e.g., 2.7 vs. 3.4).
try:
urlretrieve(url, filename)
headers_list = [(k,headers[k]) for k in headers]
opener = build_opener()
opener.addheaders = headers_list
response = opener.open(url)
with open(filename, 'wb') as f:
f.write(response.read())
except Exception as e:
logging.warn('Got SSL/Connection error: %s', e)
if not args.ignore_errors:
Expand Down
2 changes: 1 addition & 1 deletion edx_dl/parsing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ def _make_url(section_soup): # FIXME: Extract from here and test

def _get_section_name(section_soup): # FIXME: Extract from here and test
try:
return section_soup.div.h3.string
return section_soup.find_all("h3", class_="section-title")[0].string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anmolsahoo25, is this still the case? Apparently, if I understood things correctly, there is some merge conflict with the recent changes that I pushed to the master branch...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rbrito , Yes. I am working on it. Will try to fix it ASAP. Pretty new to contributing on Github, so I'm just getting used to it.

except AttributeError:
return None

Expand Down