Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the section parsing due to section name not being parsed properly #491

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed the section parsing due to section name not being parsed properly #491

wants to merge 2 commits into from

Conversation

anmolsahoo25
Copy link

🚨Please review the guidelines for contributing to this repository.

Proposed changes

Fixing the 0 courses available error.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • [x ] I have read the CONTRIBUTING doc
  • [ x] I agree to contribute my changes under the project's LICENSE
  • [x ] I have checked that the unit tests pass locally with my changes
  • [x ] I have checked the style of the new code (lint/pep).
  • [x ] I have added tests that prove my fix is effective or that my feature works
  • [x ] I have added necessary documentation (if appropriate)

Further comments

Due to the new structure, the make title function was returning None. In turn, the filter for the properly parsed class was failing. I have tested my code for the EdX courses I am subscribed to, and it is working,

Reviewers

@rbrito

Copy link

@Nocxy Nocxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't work with me. I still have some kind of loop.

@anmolsahoo25
Copy link
Author

Could you please post the error message?

@Nocxy
Copy link

Nocxy commented Mar 11, 2018

There's no error message. I already posted what I have.

@anmolsahoo25
Copy link
Author

Oh okay. Could you tell me the course link you are trying to download?

@Nocxy
Copy link

Nocxy commented Mar 12, 2018

Ofx: click here. I don't know why but it's downloading every course a lot of times. This time, it downloaded me 15 times the first 5 videos.

@anmolsahoo25
Copy link
Author

Strange. Seems to be working for me. Does it create separate folders for the units? Or everything in one place?

@Nocxy
Copy link

Nocxy commented Mar 12, 2018 via email

@anmolsahoo25
Copy link
Author

Would be great if you could share the screenshot?

@Nocxy
Copy link

Nocxy commented Mar 16, 2018 via email

@Nocxy
Copy link

Nocxy commented Mar 16, 2018 via email

@anmolsahoo25
Copy link
Author

Hey. My bad. I saw the issue where you had posted the screenshots. Sorry about that.

Copy link
Member

@rbrito rbrito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. As soon as you fix the merge conflict, I will pull your request and merge it.

Thanks.

@@ -376,7 +376,7 @@ def _make_url(section_soup): # FIXME: Extract from here and test

def _get_section_name(section_soup): # FIXME: Extract from here and test
try:
return section_soup.div.h3.string
return section_soup.find_all("h3", class_="section-title")[0].string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anmolsahoo25, is this still the case? Apparently, if I understood things correctly, there is some merge conflict with the recent changes that I pushed to the master branch...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rbrito , Yes. I am working on it. Will try to fix it ASAP. Pretty new to contributing on Github, so I'm just getting used to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants