Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpm_ostree/deploy: block on driver registration #599

Merged
merged 1 commit into from
Jul 16, 2021
Merged

rpm_ostree/deploy: block on driver registration #599

merged 1 commit into from
Jul 16, 2021

Conversation

kelvinfan001
Copy link
Member

Do not send a reply to the update_agent actor until the
rpm_ostree actor has successfully registered as driver. This
effectively blocks Zincati initialization on driver registration.
We consider failures to register as driver as transient failures,
so the rpm_ostree actor will keep retrying forever.

Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me!

src/rpm_ostree/cli_deploy.rs Outdated Show resolved Hide resolved
Do not send a reply to the `update_agent` actor until the
`rpm_ostree` actor has successfully registered as driver. This
effectively blocks Zincati initialization on driver registration.
We consider failures to register as driver as transient failures,
so the `rpm_ostree` actor will keep retrying forever.
@kelvinfan001 kelvinfan001 added this to the vNext milestone Jul 12, 2021
@kelvinfan001 kelvinfan001 merged commit b9c81b0 into coreos:main Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error failed to register as driver: rpm-ostree deploy –register-driver failed
2 participants