update_agent: remove unused Results
#610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the `tick_` functions returned a `Result`, but only two of these functions would ever return the `Err` variant. Even in the case where the returned `Result` was of the `Err` variant, the caller does not really do anything with it. Since we already do a good amount of error logging in the inner functions, refactor the `tick_` functions to return `()` instead.
lucab
reviewed
Jul 28, 2021
For helpers that return a `Result`, move error logging to the caller functions. Refactor `register_driver` to return `()`, because errors shouldn't be returned since #599. Use `anyhow::Result`. Refactor `tick_finalize_update` to return early to avoid deeply nested if-else statements.
lucab
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update_agent: remove unused
ResultsPreviously, the
tick_functions returned aResult, but only twoof these functions would ever return the
Errvariant. Even in thecase where the returned
Resultwas of theErrvariant, the callerdoes not really do anything with it.
Since we already do a good amount of error logging in the inner
functions, refactor the
tick_functions to return()instead.update_agent: misc cleanup
For helpers that return a
Result, move error logging to the callerfunctions.
Refactor
register_driverto return(), because errors shouldn'tbe returned since #599.
Use
anyhow::Result.Refactor
tick_finalize_updateto return early to avoid deeply nestedif-else statements.