Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose authentication challenge callback to support iOS WKWebView #12

Merged
merged 5 commits into from
Jan 17, 2022

Conversation

brodycj
Copy link
Contributor

@brodycj brodycj commented Dec 21, 2021

expose "didReceiveAuthenticationChallenge:completionHandler:completionHandler:" callback
from ClientCertificate plugin object to support iOS WKWebView

resolves #7

requires support from cordova-ios as I proposed in:

IMPORTANT NOTES:

  • requires CORS support to be enabled in both the Cordova app and on the server
  • breaks UIWebView support from cordova-ios pre-6.x (see TODO item below)

TODO:

  • cleanup logging
  • cleanup some comments
  • find a way to do this without breaking UIWebView support (cordova-ios pre-6.x)
  • describe this solution in a comment in issue iOS WKWebView support needed #7
  • update documentation

expose didReceiveAuthenticationChallenge:completionHandler: callback
from ClientCertificate plugin object

requires support from cordova-ios as proposed in this branch:
https://github.com/brodybits/cordova-ios/tree/auth-challenge-callback-support

NOTICE: These changes clobber the existing functionality from
CustomHTTPProtocol that was working with UIWebView (cordova-ios pre-6.x)
brodycj added a commit to brodycj/cordova-plugin-ios-xhr that referenced this pull request Jan 17, 2022
using cordova-plugin-client-certificate-support with this proposal:

- cordova-ccafix/cordova-plugin-client-certificate-support#12
brodycj added a commit to brodycj/cordova-plugin-ios-xhr that referenced this pull request Jan 17, 2022
using cordova-plugin-client-certificate-support with this proposal:

- cordova-ccafix/cordova-plugin-client-certificate-support#12
@brodycj brodycj changed the title expose didReceiveAuthenticationChallenge callback from plugin to support iOS WKWebView expose authentication challenge callback to support iOS WKWebView Jan 17, 2022
@brodycj brodycj marked this pull request as ready for review January 17, 2022 03:15
@brodycj brodycj merged commit 3cbb255 into master Jan 17, 2022
@brodycj
Copy link
Contributor Author

brodycj commented Jan 17, 2022

I raised issue #13 to get this documented properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS WKWebView support needed
1 participant