Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client certificate authentication #1

Merged
merged 1 commit into from
Jan 17, 2022
Merged

client certificate authentication #1

merged 1 commit into from
Jan 17, 2022

Conversation

brodycj
Copy link
Owner

@brodycj brodycj commented Dec 21, 2021

Adds support for client certificate authentication, using this plugin for the bulk of the functionality: https://github.com/cordova-ccafix/cordova-plugin-client-certificate-support

These changes require cordova-plugin-client-certificate-support with changes from cordova-ccafix/cordova-plugin-client-certificate-support#12 in order to build properly. Here is the recommended command to install the prerequisite plugin:

cordova plugin add github:cordova-ccafix/cordova-plugin-client-certificate-support#expose-auth-challenge-callback

TODO:

  • add explicit plugin dependency
  • clean up comments
  • clean up logging
  • This PR is targeting an unstable @brodybits fork; need to get @brodybits fork stable first
  • I may also rename the XHR plugin version that will provide this client certificate authentication functionality.

@brodycj brodycj changed the base branch from unstable-brodybits-fork to main January 17, 2022 01:45
using cordova-plugin-client-certificate-support with this proposal:

- cordova-ccafix/cordova-plugin-client-certificate-support#12
@brodycj brodycj marked this pull request as ready for review January 17, 2022 01:51
@brodycj brodycj merged commit afac9bb into main Jan 17, 2022
@brodycj
Copy link
Owner Author

brodycj commented Jan 17, 2022

Now published in @brodybits/cordova-plugin-ios-xhr version 0.0.1-rc01

Tracking followup TODO items in issue #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant