cmd/kvpctl: hardcode Ignition config key prefix; fix get argument validation
#42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignition config keys will always start with "ignition.config.", so don't require users to explicitly specify that prefix. Signed-off-by: Benjamin Gilbert <[email protected]>
The `get` subcommand allowed four arguments but not three, which should have been the other way around. Signed-off-by: Benjamin Gilbert <[email protected]>
travier
approved these changes
Jul 19, 2023
|
LGTM |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bgilbert, n1hility, travier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks! Could we get a new release with an updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignition config keys will always start with
ignition.config., so don't require users to explicitly specify that prefix.Also, the
getsubcommand allowed four arguments but not three, which should have been the other way around.cc @baude. Could we get a new release build that we could point users to?