Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for Microsoft Hyper-V #545

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Conversation

baude
Copy link
Contributor

@baude baude commented May 8, 2023

Add instructions on how to boot Fedora CoreOS using the Microsoft Hyper-V hypervisor. The instructions cover a basic how-to for setting up the VM as well as specific information needed for Ignition to work properly. This is in support of coreos/fedora-coreos-tracker#1424.

modules/ROOT/pages/provisioning-hyperv.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/provisioning-hyperv.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/provisioning-hyperv.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/provisioning-hyperv.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/provisioning-hyperv.adoc Outdated Show resolved Hide resolved
@baude
Copy link
Contributor Author

baude commented Jun 19, 2023

Updated based on review comments

modules/ROOT/pages/provisioning-hyperv.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/provisioning-hyperv.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/provisioning-hyperv.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/provisioning-hyperv.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/provisioning-hyperv.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/provisioning-hyperv.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/provisioning-hyperv.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/provisioning-hyperv.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/provisioning-hyperv.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/provisioning-hyperv.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/provisioning-hyperv.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/provisioning-hyperv.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/provisioning-hyperv.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/provisioning-hyperv.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/provisioning-hyperv.adoc Outdated Show resolved Hide resolved
@bgilbert bgilbert force-pushed the hyperv branch 2 times, most recently from 84bfd96 to c522957 Compare July 10, 2023 23:35
@bgilbert bgilbert changed the title Add documentation for Microsoft HyperV Add documentation for Microsoft Hyper-V Jul 10, 2023
@bgilbert
Copy link
Contributor

I've done some additional reworking and documented the Secure Boot issues with Generation 2 VMs. This is ready for another review.

@bgilbert bgilbert requested a review from dustymabe July 19, 2023 05:20
@bgilbert
Copy link
Contributor

Yup! I believe @dustymabe is planning to review this though.

Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good - a few comments/suggestions but overall LGTM

modules/ROOT/pages/provisioning-hyperv.adoc Show resolved Hide resolved
modules/ROOT/pages/provisioning-hyperv.adoc Outdated Show resolved Hide resolved
@bgilbert
Copy link
Contributor

Updated!

Add instructions on how to boot Fedora CoreOS using the Microsoft Hyper-V
hypervisor.  The instructions cover a basic how-to for setting up the VM
as well as specific information needed for Ignition to work properly.

See coreos/fedora-coreos-tracker#1424.

Co-authored-by: Brent Baude <[email protected]>
Co-authored-by: Nikolas Grottendieck <[email protected]>
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thank you @baude for working on this and @bgilbert for picking it up and pushing it over the finish line!

@bgilbert bgilbert merged commit a2a8ceb into coreos:main Jul 21, 2023
1 check passed
@bgilbert
Copy link
Contributor

Hyper-V images will be available in the next set of FCOS releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants