-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to rattler-build #83
base: main
Are you sure you want to change the base?
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/recipe.yaml: This is a rattler-build recipe and not yet lintable. We are working on it! |
a82ba10
to
70e47af
Compare
There's a subtle behaviour change in how |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/recipe.yaml: This is a v1 recipe and not yet lintable. We are working on it! |
I've re-triggered some builds to see if |
Interesting - on windows,
|
We can see that the
Which breaks the tests, since they require 11.0. |
Strange because |
Perhaps another little 🐞 hiding in |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you but ran into some issues. Please check the output logs of the GitHub actions workflow below for more details. You can also ping conda-forge/core for further assistance or you can try [rerendering locally](https://conda-forge.org/docs/maintainer/updating_pkgs.html#rerendering-with-conda-smithy-locally. The following suggestions might help debug any issues:
This message was generated by GitHub actions workflow run https://github.com/conda-forge-webservices/actions/runs/11139428595. |
FYI @wolfv @beckermr |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/recipe.yaml:
|
Nevermind, that's almost certainly because I monkey-patched my local install (xref prefix-dev/rattler-build-conda-compat#56). |
@wolfv, Looks like a |
An issue with a small reproducer would be great :) |
And now it's slightly less minimal, but actually reproduces the problem 😅 |
@wolfv, thanks for the new rattler-build release! Looking better now (had to disable interactions with ci-setup, which cannot handle On
and on
Difference is related to the outputs somehow, i.e. |
Yes, awesome. Thanks for retrying! On win-64 it fails during test-execution if I see correctly. The win-arm64 issue is curious. Will have to investigate (but looks fixable!). |
Is this how test failures generally look, or are we running into specific case here? If it's due to a failing test (and not some problem in the supporting infra), I'd want to have much more information about which line or assertion failed, rather than
Cool, thanks! |
@h-vetinari if you have an idea about a different way of invoking |
Just execute the individual instructions from the test section line-by-line? |
I don't think that's the best solution as that's pretty different to other script executions. If it's in a Btw. for package content tests, you can use the new |
I think this is what conda-build does (but don't know); I'm not talking about the content of some
should be executed one-by-one (and that principle can even apply to all platforms), because you really want to know at which line things failed, and not just "in the test section".
Sure, that'll cover most cases I hope. But wherever we run things that cannot be translated to other tests under |
It also doesn't work here because we have a lib that doesn't follow the standard naming pattern ( |
You can still use globs to check etc. make them platform independent and so on. All these cases are easily covered. |
Thanks, I guess using
However, we often want to specifically check the absence of something, mostly that there's no static library. I don't see how that's covered yet. |
Yes, we already have the design for negative globs as well :) prefix-dev/rattler-build#915 |
…f7eb69ba, and conda-forge-pinning 2024.09.09.04.46.35
Suggested-By: Wolf Vollprecht <[email protected]>
…nda-forge-pinning 2024.10.01.17.37.14
Another issue with missing `--experimental` in ci-setup: https://github.com/conda-forge/conda-forge-ci-setup-feedstock/blob/367229158acb6873003058534ccfdc03976f8ec4/recipe/conda_forge_ci_setup/utils.py#L76-L83
I'll try to switch to the
is a complete dealbreaker from my POV. I don't even see the inconsistency you mentioned with other script executions (well, those that are defined in a yaml list at least) - in those cases it's equally important to know which line failed. |
Definitely! If you have a simple repro I can debug or can come up with something myself |
This PR is not immediately meant for merging, but for doing a logical separation of different changes on the way to exploratory emscripten support. Builds on #82
Still needs a bunch of fixes in our infra.