Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: cannot handle __osx>=11.0 on osx-arm64? #1052

Closed
h-vetinari opened this issue Sep 9, 2024 · 9 comments
Closed

BUG: cannot handle __osx>=11.0 on osx-arm64? #1052

h-vetinari opened this issue Sep 9, 2024 · 9 comments

Comments

@h-vetinari
Copy link

Not really sure where the right place to raise this issue is, perhaps we also need to do something in smithy or conda-forge CI. However, given that conda-build works for this, I'm starting here.

As another issue from conda-forge/zlib-feedstock#83, osx-arm64 builds are failing with:

 │ │ Resolving environment for:
 │ │   Platform: osx-64
 │ │   Channels: 
 │ │    - file:///Users/runner/miniforge3/conda-bld/
 │ │    - conda-forge
 │ │   Specs:
 │ │    - __osx >=11.0
thread 'main' panicked at /Users/runner/miniforge3/conda-bld/rattler-build_1725362068760/work/src/cache.rs:171:22:
called `Result::unwrap()` on an `Err` value: DependencyResolutionError(Cannot solve the request because of: No candidates were found for __osx >=11.0.
)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
 │ │
 │ ╰─────────────────── (took 16 seconds)
 │
 ╰─────────────────── (took 17 seconds)

The images are macOS-12, so we should be satisfying __osx>=11.0 easily.

@wolfv
Copy link
Member

wolfv commented Sep 9, 2024

Ah, interesting! If this is executing on osx-64 then this should work (ie. if there is no cross-compilation going on).

But this is going to be easy to reproduce. Maybe we're missing teh virtual package injection when creating test envs.

Thanks!

@h-vetinari
Copy link
Author

Sorry, perhaps the issue title was misleading. I'm talking about cross-compilation from osx-64 to osx-arm64, not native compilation.

@wolfv
Copy link
Member

wolfv commented Sep 9, 2024

Is it supposed to run the tests? I think not and I think we need a conda-smithy release to fix it for the rattler-build case.

@h-vetinari
Copy link
Author

No, it isn't supposed to run the tests (we have no emulation, so it would necessarily fail). However, I'm already using a dev install of smithy, and something doesn't seem to be dealing with --no-test correctly

@hadim
Copy link
Contributor

hadim commented Sep 12, 2024

I might be seeing the same issue at conda-forge/xformers-feedstock#33 (comment)

@wolfv
Copy link
Member

wolfv commented Sep 12, 2024

I have a PR that would print the virtual packages. Thanks for testing @hadim - it's super helpful 🙏

@hadim
Copy link
Contributor

hadim commented Sep 12, 2024

. Thanks for testing @hadim - it's super helpful 🙏

No problem!

The issue only appears on the cf Azure CI. Do you know an easy way to test a custom rattler-build binary (from your PR) within Azure directly? (without hacking too much, the script files)

@wolfv
Copy link
Member

wolfv commented Sep 12, 2024

Unfortunately no. Will cut a release shortly

@wolfv
Copy link
Member

wolfv commented Oct 2, 2024

This was a vicious bug thanks to Apple - the system plist file reports a different version depending on which SDK it's linked against. We've rebuilt all (pixi, rattler-build and py-rattler) against the 11.0 SDK and this issue should be gone now!

Thanks to @beckermr for digging deeply and @baszalmstra for remembering something about SYSTEM_VERSION_COMPAT, and @isuruf for pointing out the solution with linking against the 11.0 SDK.

@wolfv wolfv closed this as completed Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants