Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to CMake #82

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Switch to CMake #82

wants to merge 1 commit into from

Conversation

h-vetinari
Copy link
Member

This PR is not immediately meant for merging, but for doing a logical separation of different changes on the way to exploratory emscripten support

@conda-forge-webservices
Copy link
Contributor

conda-forge-webservices bot commented Sep 8, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@h-vetinari
Copy link
Member Author

Win-arm runs into conda-forge/vc-feedstock#83, rest is fine.

@h-vetinari
Copy link
Member Author

After some more time, I actually think we should do this; definitely makes life easier & more consistent for translating to rattler adding emscripten etc.

I checked that the SOVERSION stays the same, so this should be OK also from an ABI point of view.

@isuruf
Copy link
Member

isuruf commented Oct 3, 2024

You can keep experimenting here. That's okay. However, I am not going to merge this as a maintainer. Just checking the SOVERSION is not enough as you already know. I've sent you the list of things to check from our docs before. You should check everything on that list.
Besides that, if rattler build and emscripten can't handle a such a simple build system like zlib, and needs to switch to cmake, then those systems would be dead on water.
I talked about switching to rattler-build on @conda-forge/core meeting yesterday with @wolfv and the consensus was that if the maintainers were not comfortable with switching to rattler-build just yet, nobody should force them to. Given that zlib is a package that's there on almost every env, I'm not okay with switching to rattler-build in the near future (I might consider switching to new recipe format when conda-build supports it) or cmake here.

@h-vetinari
Copy link
Member Author

If rattler build and emscripten can't handle a such a simple build system like zlib, and needs to switch to cmake

They don't need the switch to CMake, it's just way less of a hassle than dealing with autotools.

@h-vetinari h-vetinari marked this pull request as draft October 3, 2024 12:41
@h-vetinari h-vetinari mentioned this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants