-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to CMake #82
base: main
Are you sure you want to change the base?
Switch to CMake #82
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
ceec414
to
5082b13
Compare
Win-arm runs into conda-forge/vc-feedstock#83, rest is fine. |
After some more time, I actually think we should do this; definitely makes life easier & more consistent for translating to rattler adding emscripten etc. I checked that the SOVERSION stays the same, so this should be OK also from an ABI point of view. |
You can keep experimenting here. That's okay. However, I am not going to merge this as a maintainer. Just checking the SOVERSION is not enough as you already know. I've sent you the list of things to check from our docs before. You should check everything on that list. |
They don't need the switch to CMake, it's just way less of a hassle than dealing with autotools. |
This PR is not immediately meant for merging, but for doing a logical separation of different changes on the way to exploratory emscripten support