Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Notebook 7.0.8 #144

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Update to Notebook 7.0.8 #144

merged 1 commit into from
Feb 12, 2024

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Feb 9, 2024 •
edited
Loading

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jtpio
Copy link
Member Author

jtpio commented Feb 9, 2024

@conda-forge-admin, please rerender

jtpio
jtpio commented Feb 9, 2024
View reviewed changes
recipe/meta.yaml
{% set version = "7.0.7" %}
{% set lab_version = ">=4.0.7,<5" %}
{% set version = "7.0.8" %}
{% set lab_version = ">=4.0.7,<4.1" %}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relevant upstream PR: jupyter/notebook#7249

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prolly needs a repodata-patches PR, otherwise solver will just pull older ones.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(but this should land here first)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready to go, but still in draft: conda-forge/conda-forge-repodata-patches-feedstock#662

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 9, 2024

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/notebook-feedstock/actions/runs/7847727431.

bollwyvl
bollwyvl approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@bollwyvl bollwyvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will do the repodata-patches PR after this is merged

@jtpio jtpio marked this pull request as ready for review February 9, 2024 21:46
@bollwyvl bollwyvl mentioned this pull request Feb 9, 2024
Merged
5 tasks
@jtpio jtpio merged commit e54cdfe into conda-forge:main Feb 12, 2024
3 checks passed
@jtpio jtpio deleted the notebook-708 branch February 12, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bollwyvl bollwyvl bollwyvl approved these changes

@SylvainCorlay SylvainCorlay Awaiting requested review from SylvainCorlay SylvainCorlay is a code owner

@blink1073 blink1073 Awaiting requested review from blink1073 blink1073 is a code owner

@davidbrochart davidbrochart Awaiting requested review from davidbrochart davidbrochart is a code owner

@gnestor gnestor Awaiting requested review from gnestor gnestor is a code owner

@jakirkham jakirkham Awaiting requested review from jakirkham jakirkham is a code owner

@lresende lresende Awaiting requested review from lresende lresende is a code owner

@minrk minrk Awaiting requested review from minrk minrk is a code owner

@pelson pelson Awaiting requested review from pelson pelson is a code owner

@takluyver takluyver Awaiting requested review from takluyver takluyver is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtpio @bollwyvl