Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin notebook 7.0.x vs jupyterlab 4.0.x #662

Merged
merged 3 commits into from
Feb 17, 2024

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Feb 9, 2024

Checklist

  • Used a static YAML file for the patch if possible (instructions).
  • Only wrote code directly into generate_patch_json.py if absolutely necessary.
  • Ran pre-commit run -a and ensured all files pass the linting checks.
  • Ran python show_diff.py and posted the output as part of the PR.
  • Modifications won't affect packages built in the future.

References:

================================================================================
================================================================================
linux-armv7l
================================================================================
================================================================================
win-32
================================================================================
================================================================================
osx-arm64
================================================================================
================================================================================
linux-ppc64le
================================================================================
================================================================================
linux-aarch64
================================================================================
================================================================================
noarch
noarch::notebook-7.0.1-pyhd8ed1ab_0.conda
noarch::notebook-7.0.2-pyhd8ed1ab_0.conda
noarch::notebook-7.0.4-pyhd8ed1ab_0.conda
noarch::notebook-7.0.3-pyhd8ed1ab_0.conda
noarch::notebook-7.0.0-pyhd8ed1ab_0.conda
-    "jupyterlab >=4.0.2,<5",
+    "jupyterlab >=4.0.2,<4.1.0a0",
noarch::notebook-7.0.6-pyhd8ed1ab_0.conda
noarch::notebook-7.0.5-pyhd8ed1ab_0.conda
noarch::notebook-7.0.7-pyhd8ed1ab_0.conda
-    "jupyterlab >=4.0.7,<5",
+    "jupyterlab >=4.0.7,<4.1.0a0",
================================================================================
================================================================================
win-64
================================================================================
================================================================================
osx-64
================================================================================
================================================================================
linux-64

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@bollwyvl bollwyvl changed the title Pin notebook70 vs jupyterlab40 Pin notebook 7.0x vs jupyterlab 4.0.x Feb 9, 2024
@bollwyvl bollwyvl changed the title Pin notebook 7.0x vs jupyterlab 4.0.x Pin notebook 7.0.x vs jupyterlab 4.0.x Feb 9, 2024
@bollwyvl bollwyvl marked this pull request as ready for review February 12, 2024 14:21
@bollwyvl bollwyvl requested a review from a team as a code owner February 12, 2024 14:21
@bollwyvl
Copy link
Contributor Author

Still looks accurate on CI:

======================== 2 passed, 3 warnings in 1.88s =========================

patching repodata:   0%|          | 0/9 [00:00<?, ?it/s]
patching repodata:  11%|█         | 1/9 [02:53<23:10, 173.82s/it]
================================================================================
================================================================================
noarch
noarch::notebook-7.0.1-pyhd8ed1ab_0.conda
noarch::notebook-7.0.4-pyhd8ed1ab_0.conda
noarch::notebook-7.0.3-pyhd8ed1ab_0.conda
noarch::notebook-7.0.2-pyhd8ed1ab_0.conda
noarch::notebook-7.0.0-pyhd8ed1ab_0.conda
-    "jupyterlab >=4.0.2,<5",
+    "jupyterlab >=4.0.2,<4.1.0a0",
noarch::notebook-7.0.5-pyhd8ed1ab_0.conda
noarch::notebook-7.0.6-pyhd8ed1ab_0.conda
noarch::notebook-7.0.7-pyhd8ed1ab_0.conda
-    "jupyterlab >=4.0.7,<5",
+    "jupyterlab >=4.0.7,<4.1.0a0",

@bollwyvl
Copy link
Contributor Author

@conda-forge/conda-forge-repodata-patches ready for review

@xhochy xhochy merged commit a4957d5 into conda-forge:main Feb 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants