Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify run-time requirements for numpy in migrator #6301

Merged
merged 3 commits into from
Aug 18, 2024

Conversation

h-vetinari
Copy link
Member

@h-vetinari h-vetinari requested a review from a team as a code owner August 16, 2024 22:46
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Axel! 🙏

@hmaarrfk
Copy link
Contributor

The whole paragraph:

Additionally, we no longer need to use {{ pin_compatible("numpy") }} as a
run requirement - this has been handled for more than two years now by a
run-export on the numpy package itself. The migrator will therefore remove
any occurrences of this.

should be adjusted

@h-vetinari
Copy link
Member Author

I think the content of that paragraph is still correct, but I added a new one to clarify that removing pin_compatible does not mean that there shouldn't be run-requirements. Feel free to suggest ways to improve/shorten this.

recipe/migrations/numpy2.yaml Outdated Show resolved Hide resolved
@h-vetinari h-vetinari merged commit 7b06534 into conda-forge:main Aug 18, 2024
2 of 4 checks passed
@h-vetinari h-vetinari deleted the numpy branch August 18, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants