Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arch Migrator #25

Merged
merged 8 commits into from
Aug 20, 2024
Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This feedstock is being rebuilt as part of the aarch64/ppc64le migration.

Feel free to merge the PR if CI is all green, but please don't close it
without reaching out the the ARM migrators first at @conda-forge/arm-arch.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/10365156940 - please use this URL for debugging.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@loriab
Copy link
Contributor

loriab commented Aug 17, 2024

@conda-forge-admin, please rerender

@hmaarrfk
Copy link

I feel like you should bump the build number since the ci support files change so much

Copy link
Contributor

@loriab loriab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mfherbst, I think this is ready for consideration. no rush

@hmaarrfk
Copy link

I feel like hte line:

- numpy >=1.14

might be interefering with our global pinnigns.

I would:

  1. Manually copy in the numpy 2.0 migration file from https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/main/recipe/migrations/numpy2.yaml into the directory .ci_support/migrations
  2. Remove the "greater than" constraint in the host and build section.
  3. Add it to the run section

See more instructions (updated ones from)

conda-forge/conda-forge-pinning-feedstock#6301 (review)

@loriab
Copy link
Contributor

loriab commented Aug 19, 2024

@conda-forge-admin, please rerender

@loriab
Copy link
Contributor

loriab commented Aug 19, 2024

I feel like hte line:

- numpy >=1.14

might be interefering with our global pinnigns.

Done, thanks for the advice, @hmaarrfk. I'll have to look if there are other psi4 deps with numpy constraints, in case that's what's causing the persistent bot error at the np2 migration ( https://conda-forge.org/status/migration/?name=numpy2 -> bot-error -> psi4).

Copy link
Contributor

@mfherbst mfherbst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @loriab and @hmaarrfk for your help ! I'll merge this in the next few days unless someone protests.

@mnottoli you agree ?

@mnottoli
Copy link
Contributor

Looks good also to me. Thanks all for the help.

@mfherbst mfherbst merged commit 2feabc6 into conda-forge:main Aug 20, 2024
31 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the bot-pr_arch_h5b1bf3 branch August 20, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants