Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kubeflow maintainers #662

Merged
merged 4 commits into from
Nov 8, 2023
Merged

Add Kubeflow maintainers #662

merged 4 commits into from
Nov 8, 2023

Conversation

Copy link
Contributor

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

Copy link

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for creating this PR. Can we also add maintainers for the mpi-operator?
IIUC, we donated the mpi-operator to the CNCF as well: https://github.com/cncf/toc/blob/main/proposals/incubation/kubeflow.md#maintainers

cc: @terrytangyuan @alculquicondor

project-maintainers.csv Outdated Show resolved Hide resolved
@terrytangyuan
Copy link
Contributor

terrytangyuan commented Oct 31, 2023

Thank you for creating this PR. Can we also add maintainers for the mpi-operator?

IIUC, we donated the mpi-operator to the CNCF as well: https://github.com/cncf/toc/blob/main/proposals/incubation/kubeflow.md#maintainers

cc: @terrytangyuan @alculquicondor

Good catch. @annajung Could you add everyone listed in https://github.com/cncf/toc/blob/main/proposals/incubation/kubeflow.md#maintainers?

@annajung
Copy link
Contributor Author

@terrytangyuan The list of maintainers comes from the OWNERS file managed within these Kubeflow repos, which is more up to date than the proposal. If any modifications are needed in the list of maintainers not in the OWNERS file, I suggest modifying the OWNERS file first and updating the PR when it's OWNERS file has been updated.

@zijianjoy
Copy link

LGTM and cc @amye for merging this PR.

@amye
Copy link
Contributor

amye commented Oct 31, 2023

This PR touches a lot more than just Kubeflow project - please revise and only add Kubeflow.
Thanks!

@annajung
Copy link
Contributor Author

@amye sorry, misunderstood what you meant. It's been updated now to only add Kubeflow

@alculquicondor
Copy link

LGTM

@terrytangyuan
Copy link
Contributor

@annajung Thank you! Sounds good.

@amye
Copy link
Contributor

amye commented Nov 1, 2023

Much easier to have just the top level org listed instead of all orgs - you can keep your own orgs over in your repos!

@@ -1415,3 +1415,41 @@ Sandbox,kcl,Pengfei Xu,Ant Group,Peefy,https://github.com/kcl-lang/kcl/blob/main
,,Xiangfei Chen,Ant Group,NeverRaR,
,,Zheng Zhang,Ant Group,He1pa,
,,Junxing Zhu,Southeast University,jakezhu9,
Incubating,Kubeflow,James Liu,Google,zijianjoy,https://github.com/kubeflow/kubeflow/blob/master/OWNERS
,,James Wu,Google,james-jwu,
,,Pete MacKinnon,NVIDIA,pdmack,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably replace this with Josh Bottum.

@@ -1415,3 +1415,41 @@ Sandbox,kcl,Pengfei Xu,Ant Group,Peefy,https://github.com/kcl-lang/kcl/blob/main
,,Xiangfei Chen,Ant Group,NeverRaR,
,,Zheng Zhang,Ant Group,He1pa,
,,Junxing Zhu,Southeast University,jakezhu9,
Incubating,Kubeflow,James Liu,Google,zijianjoy,https://github.com/kubeflow/kubeflow/blob/master/OWNERS

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably replace myself with Thea @theadactyl

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of the org owners file, will replace this section with the interim steering committee members

Copy link

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Anna Jung (VMware) added 3 commits November 2, 2023 16:42
Signed-off-by: Anna Jung (VMware) <[email protected]>
Signed-off-by: Anna Jung (VMware) <[email protected]>
Copy link

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annajung
Copy link
Contributor Author

annajung commented Nov 3, 2023

@amye it's been updated with an aggregated list with top level instead of multiple component levels.

@amye amye merged commit f3634c0 into cncf:main Nov 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants