Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maintainers doc #657

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Conversation

annajung
Copy link
Member

@annajung annajung commented Nov 1, 2023

WG leads are listed in OWNERS files in each repo. However, there isn't one place that references all the leads.

Part of cncf/sandbox#196,

Create maintainer list + add to aggregated https://maintainers.cncf.io/ list by submitting a PR to it

This PR adds a MAINTAINERS md file that contains a reference to all the WG's OWNERS files and will be used in https://maintainers.cncf.io/

@zijianjoy @james-jwu

Signed-off-by: Anna Jung (VMware) <[email protected]>
@annajung
Copy link
Member Author

annajung commented Nov 1, 2023

This PR would help resolve this comment cncf/foundation#662 (comment) where CNCF is looking for an aggregated list. Right now, there isn't a link to support the aggregated list of maintainers and this PR would resolve that issue

Signed-off-by: Anna Jung (VMware) <[email protected]>
@zijianjoy
Copy link
Contributor

/lgtm
/approve

Thank you Anna!

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annajung
Copy link
Member Author

annajung commented Nov 3, 2023

@james-jwu can you PTAL, thanks!

@james-jwu
Copy link
Contributor

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: annajung, james-jwu, terrytangyuan, zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 28c969a into kubeflow:master Nov 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants