feat: prototype versioned app module upgrades #3729
Conversation
$ ./node
panic: error with code 2 is already registered: "duplicate"
goroutine 1 [running]:
cosmossdk.io/errors.RegisterWithGRPCCode({0x105b93b3f, 0x3}, 0x2, 0x2, {0x105b9a8f5, 0x9})
/Users/rootulp/go/pkg/mod/cosmossdk.io/[email protected]/errors.go:43 +0x240
cosmossdk.io/errors.Register(...)
/Users/rootulp/go/pkg/mod/cosmossdk.io/[email protected]/errors.go:35
github.com/celestiaorg/celestia-app/x/qgb/types.init()
/Users/rootulp/go/pkg/mod/github.com/celestiaorg/[email protected]/x/qgb/types/errors.go:8 +0x128
rootulp
force-pushed
the
rp/prototype-multi-app
branch
from
e9c0c49
to
6b08045
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
New issue: |
|
This was the error that I first got when trying to unfork the SDK. There is a global proto registry and thus when we import multiple versions we end up with this panic. One option would be to go mod the modules that way there's not two copies of |
|
Thanks for your help!
What if celestia-app v3 needs x/blob/v2 and celestia-app v1 needs x/blob/v1, then I think we'll hit the same issue where both modules try to register the same types in the global proto registry.
This one seems more hacky but potentially do-able. The concern is if celestia-app v2's |
If we created a x/blob/2 we would bump the proto version so the msg url would look like |
|
I've tried a few times to create a Go module from |
error while importing github.com/celestiaorg/celestia-app/v2/app: ambiguous import: found package github.com/celestiaorg/celestia-app/x/blob in multiple modules: github.com/celestiaorg/celestia-app v1.13.0 (/Users/rootulp/go/pkg/mod/github.com/celestiaorg/[email protected]/x/blob) github.com/celestiaorg/celestia-app/x/blob v0.0.0 (/Users/rootulp/git/rootulp/celestiaorg/celestia-app/x/blob)
|
I thought the issue might be because v1.x has an I tried cleaning the go mod cache and a few different variations of importing the x/blob package from the root |
|
The original error message makes me think that both the types MsgPayForBlobs and MsgRegisterEVMAddress don't have a proto.MessageName defined because this line should suffix it to |
That's strange. This isn't a problem in main. These two would be registered under different names |
rootulp
force-pushed
the
rp/prototype-multi-app
branch
from
3f75c5f
to
3f81028
Compare
Closes #3625
Issues encountered
errors.Register. Since the multiplexer imports multiple celestia-app versions, all errors get registered twice resulting in a:panic: error with code 2 is already registered: "duplicate". To resolve, we need to:errors.Registerto notpanicif a duplicate error is registered. Did this in https://github.com/rootulp/cosmos-sdk/releases/tag/errors%2Fv1.4.0panic: concrete type *types.MsgPayForBlobs has already been registered under typeURL /, cannot register *types.MsgRegisterEVMAddress under same typeURL. This usually means that there are conflicting modules registering different concrete types for a same interface implementation.Option A: bump the proto package versions (did in this PR)go.modfor each package and de-duplicate imports. Note: we'll have to extract thex/blobpackage from this repo so that it isn't present in the root-level celestia-app go module. Use the v2 version because it has types that aren't present in the v1 version.Remaining tasks
main. Extract the previous changes to a new v2 branch.config.IsSealedcosmos-sdk#414Commitof the block height before the upgrade height? In order to satisfy that constraint, the v2 state machine has to be updated so that modules support the range v1 to v3. If we remove v2 supporting v3 modules then we hit this errorInfo()get the version and then start that state machineNotes
make build-node && ./build/node