feat: distinct go modules for all state machine modules #3787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
added
the
backport:v2.x
rootulp
requested review from
cmwaters and
rach-id
and removed request for
rach-id
rootulp
force-pushed
the
rp/go-mod-sdk-modules
branch
from
06126fb
to
3635e92
Compare
This was an attempt to fix test-fuzz but it didn't work. The fuzz test in x/blob/types complains that an error code has already been registered. Notably this error doesn't occur during make build, make install, or runtime (i.e. ./scripts/single-node.sh).
rootulp
force-pushed
the
rp/go-mod-sdk-modules
branch
from
3635e92
to
ee71dce
Compare
This reverts commit ee71dce.
|
Discussed with Callum offline and closing this for now. As a prerequisite to this work we need to make all state machine modules not import |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblocks #3729
Description
One of the issues encountered when working on the multi-app prototype is that protobuf definitions get registered multiple times (once per state machine imported into the multiplexer). This results in errors like:
To resolve, this PR introduces distinct Go modules per state machine module. This enables the v2 and v3 state machine to import the exact same module (i.e.
github.com/celestiaorg/celestia-app/x/blob) which will result in just one proto type being registered per actual type.