Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a URL class to boa_runtime #4004

Merged
merged 4 commits into from
Oct 9, 2024

Address comments

dd57857
Select commit
Loading
Failed to load commit list.
Merged

Add a URL class to boa_runtime #4004

Address comments
dd57857
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 8, 2024 in 1s

52.84% (+5.60%) compared to 6ddc2b4

View this Pull Request on Codecov

52.84% (+5.60%) compared to 6ddc2b4

Details

Codecov Report

Attention: Patch coverage is 42.00000% with 29 lines in your changes missing coverage. Please review.

Project coverage is 52.84%. Comparing base (6ddc2b4) to head (dd57857).
Report is 269 commits behind head on main.

Files with missing lines Patch % Lines
core/runtime/src/url.rs 41.17% 20 Missing ⚠️
core/string/src/lib.rs 0.00% 5 Missing ⚠️
core/runtime/src/lib.rs 70.00% 3 Missing ⚠️
cli/src/main.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4004      +/-   ##
==========================================
+ Coverage   47.24%   52.84%   +5.60%     
==========================================
  Files         476      482       +6     
  Lines       46892    46718     -174     
==========================================
+ Hits        22154    24689    +2535     
+ Misses      24738    22029    -2709     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.