Add a URL class to boa_runtime #4004
Merged
+426
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some methods are NOT currently supported (some don' make sense outside of a browser context). They are still implemented but will throw a JavaScript Error. Supported methods should follow the specification perfectly.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4004 +/- ##
==========================================
+ Coverage 47.24% 52.84% +5.60%
==========================================
Files 476 482 +6
Lines 46892 46718 -174
==========================================
+ Hits 22154 24689 +2535
+ Misses 24738 22029 -2709 ☔ View full report in Codecov by Sentry. |
HalidOdat
added
enhancement
HalidOdat
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some methods are NOT currently supported (some don't make sense outside of a browser context). They are still implemented but will throw a JavaScript Error.
Supported methods should follow the specification perfectly and are tested for it.
Notably missing is the
URLSearchParamsclass which is complex with the current Boa API (making iterables is hard) and should be done in a separate PR.