Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with OTP 27 #35

Closed
wants to merge 1 commit into from
Closed

Conversation

whitfin
Copy link

@whitfin whitfin commented Aug 26, 2024

It looks like OTP 27 changed the signature to add :ordered, so this will match on that going forward!

@derekkraan
Copy link

@whitfin is it possible to get this merged and incorporated into a release soon? See this issue in the Horde project.

@derekkraan
Copy link

derekkraan commented Sep 3, 2024

I am still concerned about this piece of the code (also after this PR):

  1. We are matching on an opaque type.
  2. The catch-all can result in the same issue coming back if the underlying type changes shape again. It would be better if it simply errored imo.

@derekkraan
Copy link

Perhaps we can use :gb_trees.next/1 instead?

https://www.erlang.org/doc/apps/stdlib/gb_trees.html#next/1

@derekkraan
Copy link

derekkraan commented Sep 3, 2024

There is one other place where this function is being used, which is likely dropping through to the catch-all case.

I've made an attempt at adjusting the code, but I discovered that the tests aren't passing on master. Going to leave this for today.

@bitwalker
Copy link
Owner

Closing this in favor of #37

@bitwalker bitwalker closed this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants