Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backporting fixes and/or re-lowering Elixir requirements #36

Closed
whitfin opened this issue Aug 26, 2024 · 0 comments
Closed

Backporting fixes and/or re-lowering Elixir requirements #36

whitfin opened this issue Aug 26, 2024 · 0 comments

Comments

@whitfin
Copy link

whitfin commented Aug 26, 2024

This is in regards to #35.

I am maintainer of several projects using this project, but they're targeted (on the lower end) against Elixir versions prior to v1.11. It looks like in the mainline of this repository the requirement shifted to 1.11+ due to logging changes, and unfortunately I need the patch referenced above 😱

Would you consider accepting a patch to re-lower it with a conditionally compiled logging call?

if Version.match?(System.version(), ">= 1.11.0") do
  defp warn(msg),
    do: Logger.warning(msg)
else
  defp warn(msg),
    do: Logger.warn(msg)
end

As an aside, the current main branch does not compile due to invalid syntax in this snippet: https://github.com/bitwalker/libring/blob/main/lib/managed_ring.ex#L33-L45

That being said if this was made valid I think it would also affect the min Elixir version requirement by the use of optional() so that might have some impact on this thread.

I know people will say Elixir < v1.11 is "old", but enterprise moves at different speeds sometimes and I think it's fairly simple to stay compatible here. Thanks for your consideration!

@whitfin whitfin closed this as completed Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant