Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EDX-1658 Items per page footer update #1518

Merged
merged 3 commits into from
Jul 27, 2023
Merged

EDX-1658 Items per page footer update #1518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31002bf
items per page footer update
angadhsingh1 Jul 27, 2023
f6ce5da
removed footer-props
angadhsingh1 Jul 27, 2023
43d2fdc
removed itemsPerPageOptions
angadhsingh1 Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions frontend/src/components/institute/AuthoritiesList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,8 @@
id="user-search-button"
class="ml-3"
text="Search"
@click-action="searchButtonClick"
:disabled="!searchEnabled()"
@click-action="searchButtonClick"
/>
</v-col>
</v-row>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This page will likely also have a footer-props that can be cleaned up.

Also, the itemsPerPageOptions can be deleted from both pages if it isn't used anywhere else

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

Expand All @@ -147,9 +147,6 @@
v-model:page="pageNumber"
v-model:items="authorities"
v-model:items-length="totalAuthorities"
:footer-props="{
'items-per-page-options': itemsPerPageOptions
}"
:loading="loadingTable"
class="elevation-1"
hide-default-header
Expand Down Expand Up @@ -303,7 +300,6 @@ export default {
pageNumber: 1,
pageSize: 15,
totalAuthorities: 0,
itemsPerPageOptions: [15],
loadingTable: false,
dateMenu: false,
headerSearchParams: {
Expand Down Expand Up @@ -562,4 +558,7 @@ export default {
margin-right: -2em;
}

:deep(.v-data-table-footer__items-per-page) {
display: none;
}
</style>
10 changes: 5 additions & 5 deletions frontend/src/components/institute/SchoolList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,8 +258,8 @@
class="ml-3"
width="8em"
text="Search"
@click-action="searchButtonClick"
:disabled="!searchEnabled()"
@click-action="searchButtonClick"
/>
</v-col>
</v-row>
Expand All @@ -273,9 +273,6 @@
v-model:page="pageNumber"
v-model:items="schools"
v-model:items-length="totalSchools"
:footer-props="{
'items-per-page-options': itemsPerPageOptions
}"
:loading="loadingTable"
class="elevation-1"
hide-default-header
Expand Down Expand Up @@ -445,7 +442,6 @@ export default {
pageNumber: 1,
pageSize: 15,
totalSchools: 0,
itemsPerPageOptions: [15],
loadingTable: false,
dateMenu: false,
headerSearchParams: {
Expand Down Expand Up @@ -875,4 +871,8 @@ export default {
margin-right: -2em;
}

:deep(.v-data-table-footer__items-per-page) {
display: none;
}

</style>
Loading