Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDX-1658 Items per page footer update #1518

Merged
merged 3 commits into from
Jul 27, 2023
Merged

EDX-1658 Items per page footer update #1518

merged 3 commits into from
Jul 27, 2023

Conversation

angadhsingh1
Copy link
Contributor

No description provided.

:disabled="!searchEnabled()"
@click-action="searchButtonClick"
/>
</v-col>
</v-row>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This page will likely also have a footer-props that can be cleaned up.

Also, the itemsPerPageOptions can be deleted from both pages if it isn't used anywhere else

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

@mightycox mightycox merged commit bfdf5c9 into master Jul 27, 2023
1 check passed
@mightycox mightycox deleted the bugs/itemsPerPage branch July 27, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants