Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netkvm: Fix multi_nics_verify test by adding NIC initialization check #4175

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions qemu/tests/cfg/multi_nics_verify.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
network_manager = yes
RHEL.7, RHEL.8:
network_manager = no
nics_num_checking_cmd = 'ipconfig | find /c "Ethernet adapter"'
variants:
- nic_virtio:
only virtio_net
Expand Down
2 changes: 2 additions & 0 deletions qemu/tests/multi_nics_verify.py
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,8 @@ def _check_ip_number():

# Check all the interfaces in guest get ips
session_srl = vm.wait_for_serial_login(timeout=int(params.get("login_timeout", 360)))
nics_num_checking_cmd = params.get("nics_num_checking_cmd")
utils_misc.wait_for(lambda: int(session.cmd_output(nics_num_checking_cmd, timeout=360)) == nics_num, timeout=60, first=30, step=10, text="waiting for all nics to get ip")
if not utils_misc.wait_for(_check_ip_number, 1000, step=10):
test.error("Timeout when wait for nics to get ip")

Expand Down
Loading