Netkvm: Fix multi_nics_verify test by adding NIC initialization check #4175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test Result: |
|
@leidwang Could you help review this patch? Many appreciations. |
heywji
force-pushed
the
fix_multi_nic2
branch
2 times, most recently
from
fe2fd53
to
1a59acf
Compare
leidwang
reviewed
Oct 23, 2024
qemu/tests/multi_nics_verify.py
Outdated
Comment on lines
121
to
125
| while True: | ||
| status, nics_num_checking_cmd_out = session.cmd_status_output(nics_num_checking_cmd, timeout=360) | ||
| if int(nics_num_checking_cmd_out) == nics_num: | ||
| break | ||
| time.sleep(30) |
There was a problem hiding this comment.
Suggested change
| while True: | |
| status, nics_num_checking_cmd_out = session.cmd_status_output(nics_num_checking_cmd, timeout=360) | |
| if int(nics_num_checking_cmd_out) == nics_num: | |
| break | |
| time.sleep(30) | |
| utils_misc.wait_for(lambda: int(session.cmd__output(nics_num_checking_cmd, timeout=360)) == nics_num, ***, 30) |
There was a problem hiding this comment.
We need to setup an end condition for the while block, otherwise it might get stuck in an endless loop.
There was a problem hiding this comment.
Done. I will test its result ASAP.
heywji
force-pushed
the
fix_multi_nic2
branch
5 times, most recently
from
7c1cea4
to
8f7b411
Compare
The test failed because Windows didn't assign IPs to all NICs immediately after boot. A loop was added to check the NIC count until all are initialized, ensuring the test waits for all NICs to get their IP addresses before proceeding. Signed-off-by: wji <[email protected]>
heywji
force-pushed
the
fix_multi_nic2
branch
from
8f7b411
to
d54f027
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test failed because Windows didn't assign IPs to all NICs immediately after boot. A loop was added to check the NIC count until all are initialized, ensuring the test waits for all NICs to get their IP addresses before proceeding.
ID: 2393
Signed-off-by: wji [email protected]