TST: fix ISO language tests #114
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianGeng
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Indeed, this dates back to 2022. The change request in full length can be found here. North-Levantine seems to have been adopted , but as you saySouth- Levantine seems to be still there. This can easily be approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust tests for ISO languages to the changes introduced by the new iso369 library in
audformat1.3.1.Before we specified, that
"North Levantine Arabic"should map to"apc", but the correct language name is"Levantine Arabic", compare https://iso639-3.sil.org/code/apc.Maybe this was updated at some place by ISO369, as they still have
"South Levantine Arabic", but marked it as deprecated.