Add Dataset.tables_rows and show in table preview #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hagenw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs #114 to be merged first.
This adds the cached property
audbcards.Dataset.tables_rowsand uses it in the preview of the tables to add the number of rows as the last line.Under the hood, it also adds the private cached property
audbcards.Dataset._tablesto avoid loading the tables multiple times (the other occasion is insideaudbcards.Dataset.tables_preview).I'm not decided yet, if we should add
audbcards.Dataset.tables_columnsas well and state them together with the rows?If yes, I would prefer to add this in another pull request.