feat: add Visual Editor/Code Editor Switch component #691
Conversation
KhudaDad414
requested review from
fmvilas,
boyney123,
mcturco,
magicmatatjahu and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for asyncapi-studio-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for modest-rosalind-098b67 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
package.json
Outdated
| @@ -5,9 +5,11 @@ | |||
| "url": "git://github.com/asyncapi/studio.git" | |||
| }, | |||
| "scripts": { | |||
| "lint": "eslint", | |||
There was a problem hiding this comment.
so that testing workflow can run the linter.
🦋 Changeset detectedLatest commit: 9d4c315 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: Fran Méndez <[email protected]>
| @@ -0,0 +1,34 @@ | |||
| import React from 'react' | |||
| import * as Switch from '@radix-ui/react-switch' | |||
There was a problem hiding this comment.
@KhudaDad414 @fmvilas Radix-ui need an ADR ? or this was already decided in the past ?
There was a problem hiding this comment.
I saw a few radix-ui components being used so I don't know 😆
There was a problem hiding this comment.
I introduced it a few weeks ago so yeah, an ADR would be cool.
There was a problem hiding this comment.
Created an issue for this: #734
|
/rtm |
|
Hello, @KhudaDad414! 👋🏼 |
|
Kudos, SonarCloud Quality Gate passed!
|
Description
cleanscript to remove all of the build andnode_modulesfoldersRelated Issues
Resolves #673
Resolves #692