Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual Editor / Code Editor Switch component #673

Closed
Tracked by #636
fmvilas opened this issue Jun 16, 2023 · 4 comments · Fixed by #691
Closed
Tracked by #636

Visual Editor / Code Editor Switch component #673

fmvilas opened this issue Jun 16, 2023 · 4 comments · Fixed by #691
Assignees
@KhudaDad414

Comments

@fmvilas
Copy link
Member

fmvilas commented Jun 16, 2023 •
edited
Loading

Implement the Switch component as seen in the design.

Captura de pantalla 2023-06-16 a las 8 40 52

Note: Do not try to make it a generic Switch component. This one is a very special one with two icons so I would not call it Switch but, instead, EditorSwitch or something like that to avoid naming collisions with a future Switch component.

Related to #636
@fmvilas fmvilas mentioned this issue Jun 16, 2023
Closed
12 tasks
@KhudaDad414 KhudaDad414 self-assigned this Jun 18, 2023
@KhudaDad414
Copy link
Member

/progress 70

The implementation is done. just waiting for #666 to use the official tokens instead of hardcoding them in the component.

@fmvilas
Copy link
Member Author

fmvilas commented Jun 20, 2023

You got it :) #681

@KhudaDad414 KhudaDad414 mentioned this issue Jun 23, 2023
Merged
@KhudaDad414
Copy link
Member

/progress 80

#691

@KhudaDad414
Copy link
Member

/progress 95

PR is ready for review. #691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KhudaDad414 KhudaDad414

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add Visual Editor/Code Editor Switch component KhudaDad414/studio
2 participants
@fmvilas @KhudaDad414