Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [ADR-0003] use design system and ui kit #730

Merged
merged 3 commits into from
Jul 18, 2023

Conversation

Amzani
Copy link
Collaborator

@Amzani Amzani commented Jul 10, 2023

Description

Fixes #678

@changeset-bot
Copy link

changeset-bot bot commented Jul 10, 2023

⚠️ No Changeset found

Latest commit: 9b35a5b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jul 10, 2023

Deploy Preview for modest-rosalind-098b67 ready!

Name Link
🔨 Latest commit 9b35a5b
🔍 Latest deploy log https://app.netlify.com/sites/modest-rosalind-098b67/deploys/64b4efbb16bfe60008773418
😎 Deploy Preview https://deploy-preview-730--modest-rosalind-098b67.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 10, 2023

Deploy Preview for asyncapi-studio-design-system ready!

Name Link
🔨 Latest commit 9b35a5b
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-studio-design-system/deploys/64b4efbbb1477c000820a683
😎 Deploy Preview https://deploy-preview-730--asyncapi-studio-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Amzani
Copy link
Collaborator Author

Amzani commented Jul 10, 2023

@fmvilas @KhudaDad414 I need your help to create a new label kind/adr thanks

This was referenced Jul 10, 2023
@KhudaDad414
Copy link
Member

@Amzani done.

@KhudaDad414 KhudaDad414 added the kind/adr create a new architectural decision record. label Jul 10, 2023
@KhudaDad414
Copy link
Member

@Amzani GitHub Actions 🍵
they just love to fail don't they? or some might say FAIL in love 😆
https://github.com/asyncapi/studio/actions/runs/5505674481/jobs/10033342726?pr=730

@Amzani
Copy link
Collaborator Author

Amzani commented Jul 10, 2023

@KhudaDad414 you already had this issue in the past Resource not accessible by integration ? probably something wrong with the Github token I'm using.

@KhudaDad414
Copy link
Member

@Amzani it might be that since we are using GH_TOKEN in lots of actions. 🤔

@Amzani Amzani changed the title chore: [ADR-0003] use design system chore: [ADR-0003] use design system and ui kit Jul 12, 2023
@Amzani
Copy link
Collaborator Author

Amzani commented Jul 12, 2023

Hey there and thank you for opening this ADR pull request! 👋🏼 The ADR Pull request must change only the ADR file that match doc/adr/chore: -*.md You have changed theses files:

doc/adr/0003-use-design-system.md

Fixed here: #736

@sonarcloud
Copy link

sonarcloud bot commented Jul 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

Copy link
Member

@KhudaDad414 KhudaDad414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Amzani
Copy link
Collaborator Author

Amzani commented Jul 18, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit d2e2ab4 into asyncapi:master Jul 18, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/adr create a new architectural decision record. ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add some initial ADRs
4 participants