Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [ADR-0004] use RadixUI #741

Merged
merged 6 commits into from
Jul 21, 2023
Merged

Conversation

Amzani
Copy link
Collaborator

@Amzani Amzani commented Jul 17, 2023

Description

Fixes #734
Related to #730

@changeset-bot
Copy link

changeset-bot bot commented Jul 17, 2023

⚠️ No Changeset found

Latest commit: da9366b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jul 17, 2023

Deploy Preview for modest-rosalind-098b67 ready!

Name Link
🔨 Latest commit da9366b
🔍 Latest deploy log https://app.netlify.com/sites/modest-rosalind-098b67/deploys/64ba6ca921df8600087565e7
😎 Deploy Preview https://deploy-preview-741--modest-rosalind-098b67.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 17, 2023

Deploy Preview for asyncapi-studio-design-system ready!

Name Link
🔨 Latest commit da9366b
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-studio-design-system/deploys/64ba6ca9124851000801fd0b
😎 Deploy Preview https://deploy-preview-741--asyncapi-studio-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Amzani Amzani added the kind/adr create a new architectural decision record. label Jul 17, 2023
KhudaDad414
KhudaDad414 previously approved these changes Jul 17, 2023
Copy link
Member

@KhudaDad414 KhudaDad414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Amzani
Copy link
Collaborator Author

Amzani commented Jul 18, 2023

@KhudaDad414 thanks for reviewing this, could you also review #730 as it's linked

doc/adr/0004-use-radix-ui.md Outdated Show resolved Hide resolved
doc/adr/0004-use-radix-ui.md Outdated Show resolved Hide resolved
@Amzani
Copy link
Collaborator Author

Amzani commented Jul 18, 2023

/rtm

@fmvilas
Copy link
Member

fmvilas commented Jul 20, 2023

/au

@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

@Amzani
Copy link
Collaborator Author

Amzani commented Jul 21, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit fe12b7a into asyncapi:master Jul 21, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autoupdate kind/adr create a new architectural decision record. ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Radix-ui usage need an ADR
4 participants