Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADR lint failing to comment #731

Closed
Amzani opened this issue Jul 10, 2023 · 6 comments · Fixed by #732
Closed

ADR lint failing to comment #731

Amzani opened this issue Jul 10, 2023 · 6 comments · Fixed by #732
Labels
bug Something isn't working

Comments

@Amzani
Copy link
Collaborator

Amzani commented Jul 10, 2023

Describe the bug

When an ADR lint is failing, the comment action is not working
See: https://github.com/asyncapi/studio/actions/runs/5505258920/jobs/10032388819?pr=730

How to Reproduce

Steps to reproduce the issue. Attach all resources that can help us understand the issue:

Expected behavior

  • The PR should have a comment with this message This PR must be labled as kind/adr
@Amzani Amzani added bug Something isn't working good first issue Good for newcomers labels Jul 10, 2023
@depleur
Copy link

depleur commented Jul 10, 2023

Hey, I'd like to work on this. But first, I need to understand the issue a little better. Can you elaborate as to exactly when this error needs to be thrown? And also when and where this error is generated?

@Amzani
Copy link
Collaborator Author

Amzani commented Jul 10, 2023

Hi @depleur ,

Sure, this is handled by .github/workflows/check-adr.yml action.

We are also discussing the issue here: #730, probably there is something wrong with the Github Token I'm using.

@Amzani
Copy link
Collaborator Author

Amzani commented Jul 10, 2023

@depleur for now it should be a quick fix that we try to figure out #732

@Amzani
Copy link
Collaborator Author

Amzani commented Jul 10, 2023

@KhudaDad414
Copy link
Member

@Amzani pull_request_target should be used instead of pull_request to access the secrets.

@Amzani
Copy link
Collaborator Author

Amzani commented Jul 11, 2023

@KhudaDad414 works #732 thanks mate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants