-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trans: add transpiler #1
base: master
Are you sure you want to change the base?
Conversation
Also looking for ideas on where this should live |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comments in the draft.
trans.py
Outdated
|
||
|
||
parser = ArgumentParser() | ||
parser.add_argument("file", type=FileType('r'), nargs='+') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, so the idea here is that one would do e.g.:
./trans.py builds/ID/arch1/meta.json builds/ID/arch2/meta.json ...
?
Could we instead just point it at the cosa workdir and pass the ID
separately? So e.g. ./trans.py [--workdir /cosa/workdir] --build-id ID
. Then it can lookup which architectures are available using the new schema (for now, could probably just assume the basearch of the current machine if it's the old schema -- edit: or keep parsing the ref
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I switched it over to accepting a --workdir
& --build-id
. It searches for a meta.json
in all sub-directories in $workdir/builds/$buildid
. I left the actual architecture determination to parsing out coreos-assembler.basearch
.
While doing so I also dropped the --output-file
argument to instead write the output file into $workdir/builds/$buildid/release.json
every time.
Hmm, tempted to just include it in cosa. Would just need to make the Or maybe let's put it in https://github.com/coreos/fedora-coreos-releng-automation/ for now. And e.g. if RHCOS also wants to adopt this in the future, we can "upstream" it into cosa. |
|
Putting it in https://github.com/coreos/fedora-coreos-releng-automation/ for now and eventually upstreaming it into |
Still testing against plume & stream-metadata-generator