Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coreos-meta-translator: initial commit #4

Merged
merged 1 commit into from
Jul 10, 2019
Merged

Conversation

arithx
Copy link
Contributor

@arithx arithx commented Jul 5, 2019

Originally discussed in arithx/meta-transpiler#1

Tested against both plume & the fedora-coreos-stream-generator

@arithx
Copy link
Contributor Author

arithx commented Jul 8, 2019

NOTE: tested using expected directory structure while waiting for coreos/coreos-assembler#580 to land

coreos-meta-translator/trans.py Outdated Show resolved Hide resolved
coreos-meta-translator/trans.py Outdated Show resolved Hide resolved
coreos-meta-translator/trans.py Outdated Show resolved Hide resolved
coreos-meta-translator/trans.py Outdated Show resolved Hide resolved
coreos-meta-translator/trans.py Outdated Show resolved Hide resolved
coreos-meta-translator/trans.py Outdated Show resolved Hide resolved
coreos-meta-translator/trans.py Outdated Show resolved Hide resolved
coreos-meta-translator/trans.py Outdated Show resolved Hide resolved
coreos-meta-translator/trans.py Outdated Show resolved Hide resolved
@arithx
Copy link
Contributor Author

arithx commented Jul 8, 2019

Updates pushed addressing comments

Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! Mind squashing the commits before we merge?

@arithx
Copy link
Contributor Author

arithx commented Jul 10, 2019

@jlebon squashed

@jlebon jlebon merged commit 266d92f into coreos:master Jul 10, 2019
@jlebon
Copy link
Member

jlebon commented Jul 10, 2019

Next step is getting this integrated into the pipeline!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants