-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A major (performance) update on the submodule: srl-zoo; fix several issues #41~43, #46~49. #44
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ncble thanks for pointing out bugs
As the repo as been update soon after your PR,
please merge again, also fix 42 should be a bit adapted, however fix 43 seems to be good.
For fix 41 I will take a look asap.
Regarding sub-modules, please consider another PR
@@ -1,4 +1,4 @@ | |||
[submodule "srl_zoo"] | |||
path = srl_zoo | |||
branch = master | |||
url = https://github.com/araffin/srl-zoo.git | |||
url = https://github.com/ncble/srl-zoo.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, If you want to add additional fixes in srl-zoo submodule,
please do so with a PR in https://github.com/araffin/srl-zoo/.
This url shall not be changed.
environments/dataset_generator.py
Outdated
@@ -82,7 +83,7 @@ def env_thread(args, thread_num, partition=True, use_ppo2=False): | |||
(thread_num if thread_num <= args.num_episode % args.num_cpu else args.num_episode % args.num_cpu) | |||
|
|||
env.seed(seed) | |||
prng.seed(seed) # this is for the sample() function from gym.space | |||
# prng.seed(seed) # this is for the sample() function from gym.space |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the repository as been update this morning,
we now use gym==0.11.0
and already removed line 85.
Since ValueError: Seed must be between 0 and 2**32 - 1
is still remaining,
the suggested fix would be appreciated (seed = seed % 2^32).
Thanks @ncble
…vs other than mobile_robot_env.py need to be modify)
Since the srl_zoo is less popular than robotic-rl-srl, I decided to post the changelog here: Highlights
Note: Before, we need to modify 8 scripts in order to add one new model, now only two scripts (at most three): models/modules.py and models/my_custom_model.py (see the template models/new_model_template.py) ChangelogSRL part
RL part
|
Quick question: why didn't you update both changelog? (I mean the .rst files) (and I'm ok if you duplicate the srl zoo changelog to include it in the rl toolbox) |
@araffin Yes, once the code pass review, I will update then to the .rst files ;) Since there was a pull request (with OmniRobot) before mine, and I merged them directly to my branch. Now the code comparison has become a little messy, thus I will close this one and do a clean pull request again. |
Fix the following issues: