-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LD-146] Analytics Documentation #178
Merged
nowakweronika
merged 11 commits into
feature/analytic_across_the_app
from
feature/analytics_documentation
Dec 4, 2023
Merged
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
bd7639a
Add firebase info to readme.
nowakweronika 5d51ad5
Add documentation.
nowakweronika 9170398
Add reviewers screen documentation.
nowakweronika 0b9d820
[MegaLinter] Apply linters fixes
nowakweronika 1aec8dc
README improvement.
nowakweronika 6f79c70
Update reviewers_screen.md
nowakweronika 08455e8
[MegaLinter] Apply linters fixes
nowakweronika 0ee31a0
Add analytics docs for login screen.
nowakweronika 66fb8b5
[MegaLinter] Apply linters fixes
nowakweronika d07c031
Add documentation to the rest of events.
nowakweronika 41cc3d8
Add event types description.
nowakweronika File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion:
Let's move to a different file so our main README file doesn't contain too much data. e.g.
[Analytics Documentation](docs/analytics.md)
It would be good to have images in the repo, so we can do normal code-review process. So move images to GitHub repo
docs/analytics-imgs/users-in-last-30-minues.png
"Events Names" documentation, should have more information about every specific event. You can look at button_click. We should know details when something is tracked, what parameters are required. Some examples, etc.
Afaik, it would be good if every screen would have its own custom README page, e.g.
docs/anlaytics/page/reviewers-screen.md
As a start section of a given screen, it's good to add a screenshot of that page, so it's easier to know exactly what screen we're referring in the following events.
You can consider displaying images a little bit smaller, because knowing precise content is not so important, but those images take a lot of page layout.