Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LD-146] Analytics Documentation #178

Merged

Conversation

nowakweronika
Copy link
Collaborator

@nowakweronika nowakweronika commented Nov 24, 2023

Pull-Request

Description

Why?

We want to have analytics documentation in project.

What?

Firebase analytics documentation.

Links to related issues

Demo

Example part of our docs. Screenshot 2023-11-27 at 09 14 44

How to test

Take a look at the README file and let me know if you like it. 😼

Documentation

Checklist

- [ ] Functionality is covered by unit tests
- [ ] Functionality is covered by integration tests

  • I've updated PR description with relevant information
  • I've done self code review
  • I've manually tested if the code and app works

Copy link

Overall Project 73.06%

There is no coverage information present for the Files changed

Copy link

github-actions bot commented Nov 24, 2023

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ COPYPASTE jscpd yes no 2.77s
⚠️ MARKDOWN markdownlint 11 3 2 0.61s
✅ MARKDOWN markdown-link-check 11 0 2.07s
✅ MARKDOWN markdown-table-formatter 11 3 0 0.35s
✅ REPOSITORY checkov yes no 13.0s
✅ REPOSITORY devskim yes no 0.89s
✅ REPOSITORY dustilock yes no 0.12s
✅ REPOSITORY gitleaks yes no 1.26s
✅ REPOSITORY git_diff yes no 0.08s
❌ REPOSITORY secretlint yes 1 1.0s
✅ REPOSITORY syft yes no 0.33s
✅ SPELL misspell 11 0 0 0.13s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

Overall Project 73.06%

There is no coverage information present for the Files changed

@nowakweronika nowakweronika changed the title Feature/analytics documentation [LD-146] Analytics Documentation Nov 24, 2023
@@ -103,6 +105,97 @@ To do that - add `[New snapshots]` to the pull request title. Otherwise the snap

We also are having [design system documentation](components/README.md).

## 🧐 Firebase Analytics
Copy link
Member

@jacek-marchwicki jacek-marchwicki Nov 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion:

  1. Let's move to a different file so our main README file doesn't contain too much data. e.g. [Analytics Documentation](docs/analytics.md)

  2. It would be good to have images in the repo, so we can do normal code-review process. So move images to GitHub repo docs/analytics-imgs/users-in-last-30-minues.png

  3. "Events Names" documentation, should have more information about every specific event. You can look at button_click. We should know details when something is tracked, what parameters are required. Some examples, etc.

  4. Afaik, it would be good if every screen would have its own custom README page, e.g. docs/anlaytics/page/reviewers-screen.md

  5. As a start section of a given screen, it's good to add a screenshot of that page, so it's easier to know exactly what screen we're referring in the following events.

  6. You can consider displaying images a little bit smaller, because knowing precise content is not so important, but those images take a lot of page layout.

Copy link

Overall Project 73.06%

There is no coverage information present for the Files changed

Copy link

Overall Project 73.06%

There is no coverage information present for the Files changed

Copy link

Overall Project 73.06%

There is no coverage information present for the Files changed

Copy link

github-actions bot commented Dec 1, 2023

Overall Project 73.06%

There is no coverage information present for the Files changed

Copy link

github-actions bot commented Dec 3, 2023

Overall Project 73.06%

There is no coverage information present for the Files changed

@nowakweronika nowakweronika changed the base branch from develop to feature/analytic_across_the_app December 4, 2023 08:36
@nowakweronika nowakweronika merged commit bfc231c into feature/analytic_across_the_app Dec 4, 2023
10 of 12 checks passed
@nowakweronika nowakweronika deleted the feature/analytics_documentation branch January 16, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants