-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LD-146] Analytics Documentation #178
[LD-146] Analytics Documentation #178
Conversation
|
🦙 MegaLinter status: ❌ ERROR
See detailed report in MegaLinter reports |
|
@@ -103,6 +105,97 @@ To do that - add `[New snapshots]` to the pull request title. Otherwise the snap | |||
|
|||
We also are having [design system documentation](components/README.md). | |||
|
|||
## 🧐 Firebase Analytics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion:
-
Let's move to a different file so our main README file doesn't contain too much data. e.g.
[Analytics Documentation](docs/analytics.md)
-
It would be good to have images in the repo, so we can do normal code-review process. So move images to GitHub repo
docs/analytics-imgs/users-in-last-30-minues.png
-
"Events Names" documentation, should have more information about every specific event. You can look at button_click. We should know details when something is tracked, what parameters are required. Some examples, etc.
-
Afaik, it would be good if every screen would have its own custom README page, e.g.
docs/anlaytics/page/reviewers-screen.md
-
As a start section of a given screen, it's good to add a screenshot of that page, so it's easier to know exactly what screen we're referring in the following events.
-
You can consider displaying images a little bit smaller, because knowing precise content is not so important, but those images take a lot of page layout.
|
|
|
|
|
bfc231c
into
feature/analytic_across_the_app
Pull-Request
Description
Why?
We want to have analytics documentation in project.
What?
Firebase analytics documentation.
Links to related issues
Demo
How to test
Take a look at the README file and let me know if you like it. 😼
Documentation
Checklist
- [ ] Functionality is covered by unit tests- [ ] Functionality is covered by integration tests