Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [C++][CI] Move ThreadSanitizer build to Ubuntu 24.04 #44159

Merged
merged 1 commit into from
Sep 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cpp/cmake_modules/ThirdpartyToolchain.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -5002,6 +5002,10 @@ macro(build_awssdk)
string(APPEND AWS_C_FLAGS " -Wno-error=shorten-64-to-32")
string(APPEND AWS_CXX_FLAGS " -Wno-error=shorten-64-to-32")
endif()
if(NOT MSVC)
string(APPEND AWS_C_FLAGS " -Wno-deprecated")
string(APPEND AWS_CXX_FLAGS " -Wno-deprecated")
endif()

set(AWSSDK_COMMON_CMAKE_ARGS
${EP_COMMON_CMAKE_ARGS}
Expand Down
8 changes: 4 additions & 4 deletions dev/tasks/tasks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1182,16 +1182,16 @@ tasks:
flags: "-e ARROW_ENABLE_THREADING=OFF"
image: ubuntu-cpp

test-ubuntu-20.04-cpp-thread-sanitizer:
test-ubuntu-24.04-cpp-thread-sanitizer:
ci: github
template: docker-tests/github.linux.yml
params:
env:
# clang-tools and llvm version need to be synchronized so as
# to have the right llvm-symbolizer version
CLANG_TOOLS: 11
LLVM: 11
UBUNTU: 20.04
CLANG_TOOLS: 18
LLVM: 18
UBUNTU: 24.04
image: ubuntu-cpp-thread-sanitizer

test-ubuntu-20.04-cpp-minimal-with-formats:
Expand Down
4 changes: 2 additions & 2 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -651,10 +651,10 @@ services:
ARROW_BUILD_STATIC: "OFF"
ARROW_CTEST_TIMEOUT: 500
ARROW_ENABLE_TIMING_TESTS: # inherit
ARROW_DATASET: "ON"
ARROW_FLIGHT: "OFF"
ARROW_FLIGHT_SQL: "OFF"
ARROW_JEMALLOC: "OFF"
ARROW_ORC: "OFF"
ARROW_S3: "OFF"
ARROW_USE_TSAN: "ON"
command: *cpp-command

Expand Down
Loading