Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [C++][CI] Move ThreadSanitizer build to Ubuntu 24.04 #44159

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Sep 18, 2024

  1. Update Crossbow ThreadSanitizer build to use newer Ubuntu LTS
  2. Enable S3 as it passes on 24.04
  3. Disable Flight as it produces numerous errors on 24.04 (see [C++][Flight] TSan failures on Ubuntu 22.04 #36552)

1. Update Crossbow ThreadSanitizer build to use newer Ubuntu LTS
2. Enable S3 as it passes on 24.04
3. Disable Flight as it produces numerous errors on 24.04 (see apacheGH-36552)
@pitrou
Copy link
Member Author

pitrou commented Sep 18, 2024

@github-actions crossbow submit test-ubuntu-24.04-cpp-thread-sanitizer

Copy link

Revision: 74734a8

Submitted crossbow builds: ursacomputing/crossbow @ actions-ff542591f6

Task Status
test-ubuntu-24.04-cpp-thread-sanitizer GitHub Actions

@pitrou pitrou marked this pull request as ready for review September 18, 2024 11:29
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit acf15bb into apache:main Sep 18, 2024
63 of 64 checks passed
@kou kou removed the awaiting review Awaiting review label Sep 18, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Sep 18, 2024
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit acf15bb.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them.

@pitrou pitrou deleted the cpp-thread-sanitizer-ubuntu branch September 19, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants