Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-43874: [CI][Integration][Go] Use apache/arrow-go #44142

Merged
merged 4 commits into from
Sep 18, 2024

Conversation

kou
Copy link
Member

@kou kou commented Sep 17, 2024

Rationale for this change

The Go implementation is moving to apache/arrow-go from go/ in apache/arrow.

What changes are included in this PR?

Use apache/arrow-go for integration test.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

Copy link

⚠️ GitHub issue #43874 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Sep 17, 2024
Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM, I suppose we remove the integration verification once we remove all go related from our Release scripts:
https://github.com/apache/arrow/blob/main/dev/release/verify-release-candidate.sh#L1297

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Sep 17, 2024
@kou
Copy link
Member Author

kou commented Sep 18, 2024

Ah, we can remove the integration verification before we remove go/ from apache/arrow.
Because we don't release go/ in the next release.

I've opened #44152 for it.

@kou kou merged commit 3f514f2 into apache:main Sep 18, 2024
59 of 61 checks passed
@kou kou removed the awaiting merge Awaiting merge label Sep 18, 2024
@kou kou deleted the ci-integration-go branch September 18, 2024 00:55
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 3f514f2.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants