-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-43874: [CI][Integration][Go] Use apache/arrow-go #44142
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes LGTM, I suppose we remove the integration verification once we remove all go related from our Release scripts:
https://github.com/apache/arrow/blob/main/dev/release/verify-release-candidate.sh#L1297
Ah, we can remove the integration verification before we remove I've opened #44152 for it. |
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 3f514f2. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
The Go implementation is moving to apache/arrow-go from go/ in apache/arrow.
What changes are included in this PR?
Use apache/arrow-go for integration test.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.