-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-43873: [Go][CI] Remove Go related test CI #44143
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This PR should be merged after: #44142 in order to fix the integration error as we don't require the local |
@@ -1866,7 +1801,6 @@ services: | |||
jdk: 17 | |||
maven: ${MAVEN} | |||
node: ${NODE} | |||
go: ${GO} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we always use the latest Go in ci/docker/conda-integration.dockerfile
?
https://github.com/apache/arrow-go/blob/12482ca3eb1cd4da21c45325e174f1dac871281b/dev/release/verify_rc.sh#L137-L156 may help us.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried something here: 3d2516d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 4013815. There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. It also includes information about 13 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
The Go implementation is moving to apache/arrow-go from go/ in apache/arrow.
What changes are included in this PR?
CI has been migrated to apache/arrow-go repository.
Are these changes tested?
No
Are there any user-facing changes?
No