-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-43393: [C++][Parquet] parquet-dump-footer: Remove redundant link and fix --debug processing #43375
Conversation
6dd46cd
to
6738c96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you open a new issue instead of reusing an existing issue?
Our script doesn't support multiple PRs per issue.
Could you open a new issue instead of reusing an existing issue? |
I opted for MINOR. |
|
1 similar comment
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit bc98167. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Rationale for this change
libarrow
explicitly becauseparquet_shared
/parquet_static
does it automatically--help
shows--debug
but the implementation accepts--json
not--debug
What changes are included in this PR?
libarrow
link--debug
not--json
Are these changes tested?
Manually.
Are there any user-facing changes?
Yes.